Re: Dependency of USB_DWC3_XILINX on ARCH_VERSAL

From: Felipe Balbi
Date: Wed Aug 18 2021 - 06:04:46 EST



Hi Lukas,

Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> writes:
> Commit 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms")
> adds the config USB_DWC3_XILINX, which depends on the config
> ARCH_VERSAL. However, the config ARCH_VERSAL is not defined in the
> current mainline kernel repository.
>
> Will a definition of ARCH_VERSAL follow eventually (soon?) for
> mainline, is there just a further out-of-tree development for which
> the dependency is useful or is this just a mistake and can be
> corrected?

IMHO, we should have COMPILE_TEST added. Something like this:

modified drivers/usb/dwc3/Kconfig
@@ -151,7 +151,7 @@ config USB_DWC3_IMX8MP

config USB_DWC3_XILINX
tristate "Xilinx Platforms"
- depends on (ARCH_ZYNQMP || ARCH_VERSAL) && OF
+ depends on (ARCH_ZYNQMP || ARCH_VERSAL || COMPILE_TEST) && OF
default USB_DWC3
help
Support Xilinx SoCs with DesignWare Core USB3 IP.

Care to test, please

--
balbi