Re: [PATCH v8 06/34] dt-bindings: clock: tegra-car: Document new tegra-clocks sub-node

From: Dmitry Osipenko
Date: Tue Aug 17 2021 - 21:44:38 EST


18.08.2021 04:15, Rob Herring пишет:
>> + tegra-clocks:
>> + description: child nodes are the output clocks from the CAR
>> + type: object
>> +
>> + patternProperties:
>> + "^[a-z]+[0-9]+$":
>> + type: object
>> + properties:
>> + compatible:
>> + allOf:
>> + - items:
>> + - enum:
>> + - nvidia,tegra20-sclk
>> + - nvidia,tegra30-sclk
>> + - nvidia,tegra30-pllc
>> + - nvidia,tegra30-plle
>> + - nvidia,tegra30-pllm
>> + - const: nvidia,tegra-clock
> You are saying the first string must be both one of the enums and
> 'nvidia,tegra-clock'. You don't get an error because your pattern
> doesn't match 'sclk'.
>

Could you please rephrase or clarify? If pattern doesn't match 'sclk',
then it must match any other enum. I'm not sure what you're meaning.

The 'nvidia,tegra-clock' actually could be removed since it's
superfluous now. I'll consider the removal in v9.