Re: [PATCH v2 02/29] dt-bindings: mediatek: mt8195: Add binding for infra IOMMU

From: Rob Herring
Date: Tue Aug 17 2021 - 17:44:58 EST


On Fri, 13 Aug 2021 14:52:57 +0800, Yong Wu wrote:
> In mt8195, we have a new IOMMU that is for INFRA IOMMU. its masters
> mainly are PCIe and USB. Different with MM IOMMU, all these masters
> connect with IOMMU directly, there is no mediatek,larbs property for
> infra IOMMU.
>
> Another thing is about PCIe ports. currently the function
> "of_iommu_configure_dev_id" only support the id number is 1, But our
> PCIe have two ports, one is for reading and the other is for writing.
> see more about the PCIe patch in this patchset. Thus, I only list
> the reading id here and add the other id in our driver.
>
> Signed-off-by: Yong Wu <yong.wu@xxxxxxxxxxxx>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> ---
> Change note: use "contains" commented from Rob.
> ---
> .../bindings/iommu/mediatek,iommu.yaml | 13 ++++++++++++-
> .../dt-bindings/memory/mt8195-memory-port.h | 18 ++++++++++++++++++
> include/dt-bindings/memory/mtk-memory-port.h | 2 ++
> 3 files changed, 32 insertions(+), 1 deletion(-)
>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>