Re: [PATCH net v2 1/3] net: mdio-mux: Delete unnecessary devm_kfree

From: Andrew Lunn
Date: Tue Aug 17 2021 - 17:10:55 EST


On Tue, Aug 17, 2021 at 11:08:39AM -0700, Saravana Kannan wrote:
> The whole point of devm_* APIs is that you don't have to undo them if you
> are returning an error that's going to get propagated out of a probe()
> function. So delete unnecessary devm_kfree() call in the error return path.
>
> Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> Acked-by: Marc Zyngier <maz@xxxxxxxxxx>
> Tested-by: Marc Zyngier <maz@xxxxxxxxxx>
> Acked-by: Kevin Hilman <khilman@xxxxxxxxxxxx>
> Tested-by: Kevin Hilman <khilman@xxxxxxxxxxxx>

Please add a Fixes: tag, since you want this in stable.

All three patches need fixes tags, possibly different for each patch?

Andrew