Re: [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster() stub

From: Jaegeuk Kim
Date: Tue Aug 17 2021 - 14:58:25 EST


On 08/16, Nathan Chancellor wrote:
> On 8/16/2021 5:33 PM, Jaegeuk Kim wrote:
> > Hi Nathan,
> >
> > On 08/16, Nathan Chancellor wrote:
> > > Without this, there is a warning in nearly every fs/f2fs/ file when
> > > F2FS_FS_COMPRESSION is not set:
> > >
> > > In file included from fs/f2fs/super.c:31:
> > > fs/f2fs/f2fs.h:4251:13: warning: unused function 'f2fs_sanity_check_cluster' [-Wunused-function]
> > > static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
> > > ^
> > > 1 warning generated.
> > >
> > > Fixes: 1495870233e7 ("f2fs: compress: do sanity check on cluster")
> >
> > This has not been merged yet, so if you don't mind, can I integrate your fix in
> > the original patch?
>
> Sure thing!

Thanks~ :)

>
> Cheers,
> Nathan