[PATCH] serial: 8250_exar: Add missing call to pci_free_irq_vectors()

From: Utkarsh Verma
Date: Tue Aug 17 2021 - 13:04:26 EST


Free the pci irq vectors if the call to pci_alloc_irq_vectors() fails
or if the device is removed.

Signed-off-by: Utkarsh Verma <utkarshverma294@xxxxxxxxx>
---
drivers/tty/serial/8250/8250_exar.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
index 3ffeedc29c83..38b65d6980f5 100644
--- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -627,8 +627,10 @@ exar_pci_probe(struct pci_dev *pcidev, const struct pci_device_id *ent)
pci_set_master(pcidev);

rc = pci_alloc_irq_vectors(pcidev, 1, 1, PCI_IRQ_ALL_TYPES);
- if (rc < 0)
+ if (rc < 0) {
+ pci_free_irq_vectors(pcidev);
return rc;
+ }

memset(&uart, 0, sizeof(uart));
uart.port.flags = UPF_SHARE_IRQ | UPF_EXAR_EFR | UPF_FIXED_TYPE | UPF_FIXED_PORT;
@@ -677,6 +679,7 @@ static void exar_pci_remove(struct pci_dev *pcidev)

if (priv->board->exit)
priv->board->exit(pcidev);
+ pci_free_irq_vectors(pcidev);
}

static int __maybe_unused exar_suspend(struct device *dev)
--
2.17.1