Re: [PATCH 5.10 12/19] vboxsf: Make vboxsf_dir_create() return the handle for the created file

From: Sudip Mukherjee
Date: Tue Aug 17 2021 - 11:56:48 EST


On Sun, Aug 15, 2021 at 2:57 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Hi,
>
> On 8/13/21 9:31 PM, Pavel Machek wrote:
> > Hi!
> >
> >> commit ab0c29687bc7a890d1a86ac376b0b0fd78b2d9b6 upstream
> >>
> >> Make vboxsf_dir_create() optionally return the vboxsf-handle for
> >> the created file. This is a preparation patch for adding atomic_open
> >> support.
> >
> > Follow up commits using this functionality are in 5.13 but not in
> > 5.10, so I believe we don't need this in 5.10, either?
> >
> > (Plus someone familiar with the code should check if we need "vboxsf:
> > Honor excl flag to the dir-inode create op" in 5.10; it may have same
> > problem).
>
> Actually those follow up commits fix an actual bug, so I was expecting
> the person who did the backport to also submit the rest of the set.

I only track Greg's failed messages when I find time for stable and
this one was one of those. So, no idea who has originally requested
this and why were the other two not requested.

--
Regards
Sudip