Re: [PATCH 2/4] dt-bindings: sound: add rockchip i2s-tdm binding
From: kernel test robot
Date: Tue Aug 17 2021 - 09:41:52 EST
Hi Nicolas,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on rockchip/for-next]
[also build test ERROR on asoc/for-next sound/for-next v5.14-rc6 next-20210816]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Nicolas-Frattaroli/Rockchip-I2S-TDM-controller/20210817-181921
base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3b075f992be5028cbbe3ab1fbdf95bb63bbdac0c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nicolas-Frattaroli/Rockchip-I2S-TDM-controller/20210817-181921
git checkout 3b075f992be5028cbbe3ab1fbdf95bb63bbdac0c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
sound/soc/rockchip/rockchip_i2s_tdm.c: In function 'rockchip_snd_xfer_reset_assert':
>> sound/soc/rockchip/rockchip_i2s_tdm.c:198:25: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration]
198 | writeq(val, addr);
| ^~~~~~
| writel
cc1: some warnings being treated as errors
vim +198 sound/soc/rockchip/rockchip_i2s_tdm.c
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 167
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 168 static void rockchip_snd_xfer_reset_assert(struct rk_i2s_tdm_dev *i2s_tdm,
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 169 int tx_bank, int tx_offset,
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 170 int rx_bank, int rx_offset)
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 171 {
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 172 void __iomem *cru_reset, *addr;
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 173 unsigned long flags;
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 174 u64 val;
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 175
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 176 cru_reset = i2s_tdm->cru_base + i2s_tdm->soc_data->softrst_offset;
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 177
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 178 switch (abs(tx_bank - rx_bank)) {
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 179 case 0:
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 180 writel(BIT(tx_offset) | BIT(rx_offset) |
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 181 (BIT(tx_offset) << 16) | (BIT(rx_offset) << 16),
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 182 cru_reset + (tx_bank * 4));
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 183 break;
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 184 case 1:
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 185 if (tx_bank < rx_bank) {
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 186 val = BIT(rx_offset) | (BIT(rx_offset) << 16);
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 187 val <<= 32;
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 188 val |= BIT(tx_offset) | (BIT(tx_offset) << 16);
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 189 addr = cru_reset + (tx_bank * 4);
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 190 } else {
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 191 val = BIT(tx_offset) | (BIT(tx_offset) << 16);
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 192 val <<= 32;
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 193 val |= BIT(rx_offset) | (BIT(rx_offset) << 16);
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 194 addr = cru_reset + (rx_bank * 4);
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 195 }
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 196
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 197 if (IS_ALIGNED((uintptr_t)addr, 8)) {
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 @198 writeq(val, addr);
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 199 break;
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 200 }
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 201 fallthrough;
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 202 default:
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 203 local_irq_save(flags);
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 204 writel(BIT(tx_offset) | (BIT(tx_offset) << 16),
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 205 cru_reset + (tx_bank * 4));
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 206 writel(BIT(rx_offset) | (BIT(rx_offset) << 16),
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 207 cru_reset + (rx_bank * 4));
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 208 local_irq_restore(flags);
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 209 break;
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 210 }
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 211 }
2a497b883a8aaf Nicolas Frattaroli 2021-08-17 212
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip