Re: [PATCH] media: ov8856: Set default mbus format but allow caller to alter

[Hsin-Yi Wang]

On Wed, Jul 28, 2021 at 7:22 PM Robert Foss <robert.foss@xxxxxxxxxx> wrote:
>
> Hey Hsin-Yi,
>
> Thanks for looking into this.
>
> On Mon, 5 Jul 2021 at 10:17, Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote:
> >
> > Setting the value of V_WIN_OFF (0x3818) from 0x02 to 0x01 to use GRBG
> > format still results in wrong color output if data is tuned in BGGR mode
> > before.
> >
> > Set default mbus format for the supported modes, but allow the caller of
> > set(get)_fmt to change the bayer format between BGGR and GRBG.
> >
> > Set the default mbus format for 3264x2448 (and 1632x1224) to BGGR as the
> > data sheet states the value of this reg should be 0x02 by default.
> >
> > If new modes are added in the future, they can add the
> > mipi_data_mbus_{format} settings into bayer_offset_configs to adjust their
> > offset regs.
> >
> > Fixes: 2984b0ddd557 ("media: ov8856: Configure sensor for GRBG Bayer for all modes")
> > Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
> > ---
<snip>
>
> Looks good to me.
>
> Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>

Hello maintainers,

kindly ping on this patch, thanks!