Re: [PATCH v5, 13/15] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192

From: yunfei.dong@xxxxxxxxxxxx
Date: Mon Aug 16 2021 - 23:39:22 EST


Hi Rob,

Thanks for your detail suggestion.

For the header file(dt-bindings/clock/mt8192-clk.h) is included in:
https://patchwork.kernel.org/project/linux-mediatek/list/?series=511175

Need to depend on this patch, do you have any suggestion about how to
add it?

Thanks.

On Wed, 2021-08-11 at 11:24 -0600, Rob Herring wrote:
> On Wed, 11 Aug 2021 10:57:59 +0800, Yunfei Dong wrote:
> > Adds decoder dt-bindings for mt8192.
> >
> > Signed-off-by: Yunfei Dong <yunfei.dong@xxxxxxxxxxxx>
> > ---
> > v5: no changes
> >
> > This patch depends on "Mediatek MT8192 clock support"[1].
> >
> > The definition of decoder clocks are in mt8192-clk.h, need to
> > include them in case of build fail [1].
> >
> > [1]
> > https://patchwork.kernel.org/project/linux-mediatek/list/?series=511175
> > ---
> > .../media/mediatek,vcodec-comp-decoder.yaml | 172
> > ++++++++++++++++++
> > 1 file changed, 172 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/media/mediatek,vcodec-comp-
> > decoder.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> ./Documentation/devicetree/bindings/media/mediatek,vcodec-comp-
> decoder.yaml: $id: relative path/filename doesn't match actual path
> or filename
> expected:
> http://devicetree.org/schemas/media/mediatek,vcodec-comp-decoder.yaml#
> Documentation/devicetree/bindings/media/mediatek,vcodec-comp-
> decoder.example.dts:22:18: fatal error: dt-bindings/clock/mt8192-
> clk.h: No such file or directory
> 22 | #include <dt-bindings/clock/mt8192-clk.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[1]: *** [scripts/Makefile.lib:380:
> Documentation/devicetree/bindings/media/mediatek,vcodec-comp-
> decoder.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1419: dt_binding_check] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/1515556
>
> This check can fail if there are any dependencies. The base for a
> patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up
> to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>