Re: [PATCH] soc: qcom: socinfo: Fixed argument passed to platform_set_data()

From: Bjorn Andersson
Date: Mon Aug 16 2021 - 22:35:45 EST


On Mon 16 Aug 19:24 CDT 2021, Antonio Martorana wrote:

> Set qcom_socinfo pointer as data being stored instead of pointer
> to soc_device structure. Aligns with future calls to platform_get_data()
> which expects qcom_socinfo pointer.
>

Thanks for the patch Antonio!

This should have a fixes tag, to ensure that it's appropriately
backported.

Fixes: efb448d0a3fc ("soc: qcom: Add socinfo driver")
Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Regards,
Bjorn

> Signed-off-by: Antonio Martorana <amartora@xxxxxxxxxxxxxx>
> ---
> drivers/soc/qcom/socinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 9faf483..52e5811 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -628,7 +628,7 @@ static int qcom_socinfo_probe(struct platform_device *pdev)
> /* Feed the soc specific unique data into entropy pool */
> add_device_randomness(info, item_size);
>
> - platform_set_drvdata(pdev, qs->soc_dev);
> + platform_set_drvdata(pdev, qs);
>
> return 0;
> }
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>