Re: [PATCH] Makefile: use -Wno-main in the full kernel tree

From: Steven Rostedt
Date: Mon Aug 16 2021 - 22:06:06 EST


On Mon, 16 Aug 2021 15:31:33 -1000
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, Aug 16, 2021 at 3:01 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> >
> > That sounds likely. We can just ignore this if you had rather go that way.
>
> I'm happy doing it, I don't think the Wmain warnings buy anything for
> the kernel. My main worry is just that some compiler version might not
> support it at all or similar, and it would cause problems that way.
>
> Which is really the only reason why I'd like to narrow it down as much
> as (trivially) possible.
>
> It doesn't sound worth trying to pinpoint exact gcc version, but
> making it gcc-only would at least narrow it down a _bit_.

Looks to me that -Wmain and -Wno-main have been in gcc for a long time.
If we limit it to just gcc, I believe it will not be an issue for any
compiler version the kernel supports.

https://gcc.gnu.org/onlinedocs/gcc/Option-Index.html

And perhaps you are correct, as this is not a new option (it's in all
the gcc versions I have (tested back to 4.2.4)), and it didn't trigger
for me, I too believe this was a bug in a particular version that Randy
used.

-- Steve