RE: [PATCH v5 07/14] enic: Use irq_update_affinity_hint

[Christian Benvenuti (benve)]

> -----Original Message-----
> From: Nitesh Narayan Lal <nitesh@xxxxxxxxxx>
> Sent: Tuesday, July 20, 2021 4:26 PM
> To: linux-kernel@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; intel-wired-
> lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-api@xxxxxxxxxxxxxxx;
> linux-pci@xxxxxxxxxxxxxxx; tglx@xxxxxxxxxxxxx; jesse.brandeburg@xxxxxxxxx;
> robin.murphy@xxxxxxx; mtosatti@xxxxxxxxxx; mingo@xxxxxxxxxx;
> jbrandeb@xxxxxxxxxx; frederic@xxxxxxxxxx; juri.lelli@xxxxxxxxxx;
> abelits@xxxxxxxxxxx; bhelgaas@xxxxxxxxxx; rostedt@xxxxxxxxxxx;
> peterz@xxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx;
> sfr@xxxxxxxxxxxxxxxx; stephen@xxxxxxxxxxxxxxxxxx;
> rppt@xxxxxxxxxxxxxxxxxx; chris.friesen@xxxxxxxxxxxxx; maz@xxxxxxxxxx;
> nhorman@xxxxxxxxxxxxx; pjwaskiewicz@xxxxxxxxx;
> sassmann@xxxxxxxxxx; thenzl@xxxxxxxxxx;
> kashyap.desai@xxxxxxxxxxxx; sumit.saxena@xxxxxxxxxxxx;
> shivasharan.srikanteshwara@xxxxxxxxxxxx;
> sathya.prakash@xxxxxxxxxxxx; sreekanth.reddy@xxxxxxxxxxxx;
> suganath-prabu.subramani@xxxxxxxxxxxx; james.smart@xxxxxxxxxxxx;
> dick.kennedy@xxxxxxxxxxxx; jkc@xxxxxxxxxx; faisal.latif@xxxxxxxxx;
> shiraz.saleem@xxxxxxxxx; tariqt@xxxxxxxxxx; ahleihel@xxxxxxxxxx;
> kheib@xxxxxxxxxx; borisp@xxxxxxxxxx; saeedm@xxxxxxxxxx; Christian
> Benvenuti (benve) <benve@xxxxxxxxx>; govind@xxxxxxx;
> jassisinghbrar@xxxxxxxxx; ajit.khaparde@xxxxxxxxxxxx;
> sriharsha.basavapatna@xxxxxxxxxxxx; somnath.kotur@xxxxxxxxxxxx;
> nilal@xxxxxxxxxx; tatyana.e.nikolova@xxxxxxxxx; mustafa.ismail@xxxxxxxxx;
> ahs3@xxxxxxxxxx; leonro@xxxxxxxxxx; chandrakanth.patil@xxxxxxxxxxxx;
> bjorn.andersson@xxxxxxxxxx; chunkuang.hu@xxxxxxxxxx;
> yongqiang.niu@xxxxxxxxxxxx; baolin.wang7@xxxxxxxxx;
> poros@xxxxxxxxxx; minlei@xxxxxxxxxx; emilne@xxxxxxxxxx;
> jejb@xxxxxxxxxxxxx; martin.petersen@xxxxxxxxxx; _govind@xxxxxxx;
> kabel@xxxxxxxxxx; viresh.kumar@xxxxxxxxxx; Tushar.Khandelwal@xxxxxxx;
> kuba@xxxxxxxxxx
> Subject: [PATCH v5 07/14] enic: Use irq_update_affinity_hint
> 
> The driver uses irq_set_affinity_hint() to update the affinity_hint mask that
> is consumed by the userspace to distribute the interrupts. However, under
> the hood irq_set_affinity_hint() also applies the provided cpumask (if not
> NULL) as the affinity for the given interrupt which is an undocumented side
> effect.
> 
> To remove this side effect irq_set_affinity_hint() has been marked as
> deprecated and new interfaces have been introduced. Hence, replace the
> irq_set_affinity_hint() with the new interface irq_update_affinity_hint() that
> only updates the affinity_hint pointer.
> 
> Signed-off-by: Nitesh Narayan Lal <nitesh@xxxxxxxxxx>

Thanks Nitesh for the patch.

Reviewed-by: Christian Benvenuti <benve@xxxxxxxxx>