RE: [PATCH v6 0/5] Add Alder Lake PCH-S support to PMC core driver

[Kammela, Gayatri]

> -----Original Message-----
> From: Hans de Goede <hdegoede@xxxxxxxxxx>
> Sent: Tuesday, August 3, 2021 5:19 AM
> To: Kammela, Gayatri <gayatri.kammela@xxxxxxxxx>; platform-driver-
> x86@xxxxxxxxxxxxxxx
> Cc: mgross@xxxxxxxxxxxxxxx; irenic.rajneesh@xxxxxxxxx;
> andriy.shevchenko@xxxxxxxxxxxxxxx; vicamo.yang@xxxxxxxxxxxxx;
> Pandruvada, Srinivas <srinivas.pandruvada@xxxxxxxxx>; Box, David E
> <david.e.box@xxxxxxxxx>; Qin, Chao <chao.qin@xxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; Mashiah, Tamar <tamar.mashiah@xxxxxxxxx>;
> gregkh@xxxxxxxxxxxxxxxxxxx; rajatja@xxxxxxxxxx; Shyam-sundar.S-
> k@xxxxxxx; Alexander.Deucher@xxxxxxx; mlimonci@xxxxxxx
> Subject: Re: [PATCH v6 0/5] Add Alder Lake PCH-S support to PMC core driver
> 
> Hi Gayatri,
> 
> 
> On 7/31/21 8:07 AM, Gayatri Kammela wrote:
> > Hi,
> > The patch series move intel_pmc_core* files to pmc subfolder as well
> > as add Alder Lake PCH-S support to PMC core driver.
> >
> > Patch 1: Move intel_pmc_core* files to pmc subfolder Patch 2: Add
> > Alderlake support to pmc core driver Patch 3: Add Latency Tolerance
> > Reporting (LTR) support to Alder Lake Patch 4: Add Alder Lake low
> > power mode support for pmc core Patch 5: Add GBE Package C10 fix for
> > Alder Lake
> >
> > Changes since v1:
> > 1) Add patch 1 to v2 i.e., Move intel_pmc_core* files to pmc subfolder.
> > 2) Modify commit message for patch 2.
> >
> > Changes since v2:
> > 1) Dropped intel_pmc_ prefix from the file names.
> >
> > Changes since v3:
> > 1) Fixed an error reported by lkp.
> >
> > Changes since v4:
> > 1) Updated MAINTAINERS
> >
> > Changes since v5:
> > 1) Fixed an module name error reported by Chao Qin
> 
> Thank you for fixing this.
> 
> I expect that you will send a new version addressing Andy's remarks, so I'm
> going to drop this version from my queue.
Hi Hans! I just sent a new version addressing Andy's comments. Thanks!
> 
> Regards,
> 
> Hans
> 
> 
> > David E. Box (1):
> >   platform/x86/intel: pmc/core: Add GBE Package C10 fix for Alder Lake
> >     PCH
> >
> > Gayatri Kammela (4):
> >   platform/x86/intel: intel_pmc_core: Move intel_pmc_core* files to pmc
> >     subfolder
> >   platform/x86/intel: pmc/core: Add Alderlake support to pmc core driver
> >   platform/x86/intel: pmc/core: Add Latency Tolerance Reporting (LTR)
> >     support to Alder Lake
> >   platform/x86/intel: pmc/core: Add Alder Lake low power mode support
> >     for pmc core
> >
> >  MAINTAINERS                                   |   2 +-
> >  drivers/platform/x86/Kconfig                  |  21 --
> >  drivers/platform/x86/Makefile                 |   1 -
> >  drivers/platform/x86/intel/Kconfig            |   1 +
> >  drivers/platform/x86/intel/Makefile           |   1 +
> >  drivers/platform/x86/intel/pmc/Kconfig        |  22 ++
> >  drivers/platform/x86/intel/pmc/Makefile       |   6 +
> >  .../{intel_pmc_core.c => intel/pmc/core.c}    | 309 +++++++++++++++++-
> >  .../{intel_pmc_core.h => intel/pmc/core.h}    |  17 +
> >  .../pmc/pltdrv.c}                             |   0
> >  10 files changed, 353 insertions(+), 27 deletions(-)  create mode
> > 100644 drivers/platform/x86/intel/pmc/Kconfig
> >  create mode 100644 drivers/platform/x86/intel/pmc/Makefile
> >  rename drivers/platform/x86/{intel_pmc_core.c => intel/pmc/core.c}
> > (85%)  rename drivers/platform/x86/{intel_pmc_core.h =>
> > intel/pmc/core.h} (95%)  rename
> > drivers/platform/x86/{intel_pmc_core_pltdrv.c => intel/pmc/pltdrv.c}
> > (100%)
> >
> > Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxx>
> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Cc: David Box <david.e.box@xxxxxxxxx>
> > Cc: You-Sheng Yang <vicamo.yang@xxxxxxxxxxxxx>
> > Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
> > Cc: Rajneesh Bhardwaj <irenic.rajneesh@xxxxxxxxx>
> > Cc: Chao Qin <chao.qin@xxxxxxxxx>
> >
> > base-commit: c7d102232649226a69dddd58a4942cf13cff4f7c
> >