Re: [PATCH 4/4] arm: dts: zynq: Replace 'io-standard' with 'power-source' property

From: Michal Simek
Date: Mon Aug 16 2021 - 05:08:29 EST


Hi Rob,

On 8/5/21 9:52 AM, Michal Simek wrote:
>
>
> On 8/2/21 7:29 PM, Rob Herring wrote:
>> On Thu, Jul 29, 2021 at 10:59 PM Michal Simek <michal.simek@xxxxxxxxxx> wrote:
>>>
>>>
>>>
>>> On 7/29/21 9:59 PM, Rob Herring wrote:
>>>> On Wed, Jul 21, 2021 at 05:22:33PM +0530, Sai Krishna Potthuri wrote:
>>>>> Replace 'io-standard' property with 'power-source' property in all zynq dts
>>>>> files to be in sync with Zynq pinctrl driver.
>>>>>
>>>>> Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xxxxxxxxxx>
>>>>> ---
>>>>> arch/arm/boot/dts/zynq-ebaz4205.dts | 8 ++++----
>>>>> arch/arm/boot/dts/zynq-microzed.dts | 2 +-
>>>>> arch/arm/boot/dts/zynq-zc702.dts | 20 ++++++++++----------
>>>>> arch/arm/boot/dts/zynq-zc706.dts | 18 +++++++++---------
>>>>> 4 files changed, 24 insertions(+), 24 deletions(-)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/zynq-ebaz4205.dts b/arch/arm/boot/dts/zynq-ebaz4205.dts
>>>>> index b0b836aedd76..be7eae611fb7 100644
>>>>> --- a/arch/arm/boot/dts/zynq-ebaz4205.dts
>>>>> +++ b/arch/arm/boot/dts/zynq-ebaz4205.dts
>>>>> @@ -57,7 +57,7 @@
>>>>>
>>>>> conf {
>>>>> groups = "gpio0_20_grp", "gpio0_32_grp";
>>>>> - io-standard = <3>;
>>>>> + power-source = <3>;
>>>>
>>>> This will break using a new DT with a kernel without patch 3.
>>>>
>>>
>>> What do you suggest? Not to update any old DT?
>>
>> Your options are don't change the dts files, patch 3 needs to go to
>> stable kernels, or you document the breakage (if you don't care).
>
> There is no intention to go to stable kernel and I don't think this is
> stable material. Linus has applied 3 patches and this one should go via
> my tree. It means I will make sure that this DT change will be in the
> tree when pinctrl changes are applied.

Any issue with this patch? Or can I apply it to my tree?

Thanks,
Michal