Re: [PATCH] media: mtk-mdp: make mtk_mdp_comp_init static

[houlong wei]

On Wed, 2021-08-11 at 15:15 +0800, Eizan Miyamoto wrote:
> This function isn't and doesn't need to be used outside of
> mtk_mdp_comp.c
> 
> This patch depends on and is a follow-up to
> 
https://patchwork.kernel.org/project/linux-mediatek/list/?series=524929
> 
> Signed-off-by: Eizan Miyamoto <eizan@xxxxxxxxxxxx>
> ---

Reviewed-by: Houlong Wei <houlong.wei@xxxxxxxxxxxx>

>  drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 2 +-
>  drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> index 9527649de98e..2cf8f1864f8c 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> @@ -234,7 +234,7 @@ static const struct component_ops
> mtk_mdp_component_ops = {
>  	.unbind = mtk_mdp_comp_unbind,
>  };
>  
> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev)
> +static int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct
> device *dev)
>  {
>  	struct device_node *larb_node;
>  	struct platform_device *larb_pdev;
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> index e3d6aef52869..aa6442cc8c1d 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> @@ -21,8 +21,6 @@ struct mtk_mdp_comp {
>  	struct device		*larb_dev;
>  };
>  
> -int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device
> *dev);
> -
>  int mtk_mdp_comp_power_on(struct mtk_mdp_comp *comp);
>  int mtk_mdp_comp_power_off(struct mtk_mdp_comp *comp);
>  
> -- 
> 2.32.0.605.g8dce9f2422-goog
>