Re: [PATCH] staging:iio:ade7854 surround complex defines in parentheses

From: Greg Kroah-Hartman
Date: Sun Aug 15 2021 - 02:26:35 EST


On Sat, Aug 14, 2021 at 07:31:15PM -0700, daniel watson wrote:
> Error found by checkpatch.pl

What error?

>
> Signed-off-by: daniel watson <ozzloy@xxxxxxxxxxxxxxxxx>

Capitalize your name?

> ---
> drivers/staging/iio/meter/ade7854.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854.h b/drivers/staging/iio/meter/ade7854.h
> index a51e6e3183d38..afb13e21002e1 100644
> --- a/drivers/staging/iio/meter/ade7854.h
> +++ b/drivers/staging/iio/meter/ade7854.h
> @@ -139,9 +139,9 @@
> #define ADE7854_MAX_RX 7
> #define ADE7854_STARTUP_DELAY 1000
>
> -#define ADE7854_SPI_SLOW (u32)(300 * 1000)
> -#define ADE7854_SPI_BURST (u32)(1000 * 1000)
> -#define ADE7854_SPI_FAST (u32)(2000 * 1000)
> +#define ADE7854_SPI_SLOW ((u32)(300 * 1000))
> +#define ADE7854_SPI_BURST ((u32)(1000 * 1000))
> +#define ADE7854_SPI_FAST ((u32)(2000 * 1000))

This is not a real change that is needed, just look at the code to
verify that.

thanks,

greg k-h