Re: [PATCH 2/3] scsi: fnic: Stop setting scsi_cmnd.tag

From: Christoph Hellwig
Date: Sat Aug 14 2021 - 03:40:01 EST


On Fri, Aug 13, 2021 at 08:17:45PM -0700, Bart Van Assche wrote:
> On 8/13/21 6:49 AM, John Garry wrote:
> > It is never read. Setting it and the request tag seems dodgy
> > anyway.
>
> This is done because there is code in the SCSI error handler that may
> allocate a SCSI command without allocating a tag. See also
> scsi_ioctl_reset().

Yes. Hannes had a great series to stop passing the pointless scsi_cmnd
to the reset methods. Hannes, any chance you coul look into
resurrecting that?