Re: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART

From: Shawn Guo
Date: Sat Aug 14 2021 - 01:23:40 EST


On Mon, Aug 09, 2021 at 10:52:04PM +0000, Leo Li wrote:
>
>
> > -----Original Message-----
> > From: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
> > Sent: Tuesday, June 15, 2021 8:16 AM
> > To: Shawn Guo <shawnguo@xxxxxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; Rob
> > Herring <robh+dt@xxxxxxxxxx>; Mark Kettenis <mark.kettenis@xxxxxxxxx>;
> > devicetree <devicetree@xxxxxxxxxxxxxxx>; linux-arm-kernel <linux-arm-
> > kernel@xxxxxxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>
> > Cc: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
> > Subject: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of
> > LX2160A UART
> >
> > Mark Kettenis told us that:
> > According to the NXP documentation, the LX2160A has a real PL011 UART.
> >
> > Therefore, rewrite it to the compatible string of pl011. The property "current-
> > speed" specific to "arm,sbsa-uart" is also deleted.
>
> Sorry that I missed the discussion on the v1. But looks like this change breaks the LX2160 boot. The AMBA matching doesn't seem to work. And the console is not registered correctly.
>
> [ 0.639055] OF: amba_device_add() failed (-2) for /soc/serial@21c0000
> [ 0.645612] OF: amba_device_add() failed (-2) for /soc/serial@21d0000

Patch dropped.

Shawn