Re: [PATCH v5 3/9] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks

[Andy Shevchenko]

On Fri, Aug 13, 2021 at 8:54 PM <jim.cromie@xxxxxxxxx> wrote:
> > > There is still plenty of bikeshedding to do.
> >
> > > ---
> > > v4+:
> > >
> > > . rename to DEFINE_DYNAMIC_DEBUG_CATEGORIES from DEFINE_DYNDBG_BITMAP
> > > . in query, replace hardcoded "i915" w kp->mod->name
> > > . static inline the stubs
> > > . const *str in structs, const array. -Emil
> > > . dyndbg: add do-nothing DEFINE_DYNAMIC_DEBUG_CATEGORIES if !DD_CORE
> > > . call MOD_PARM_DESC(name, "$desc") for users
> > > . simplify callback, remove bit-change detection
> > > . config errs reported by <lkp@xxxxxxxxx>
> > >
> > > ddh-helpers
> >
> > > Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>
> >
> > So, it is signed or not? I didn't get (perhaps due to misplaced changlog?).
> >
>
> It might be my --- snip, and reliance on format-patch -s
>
> would it work if I used --  2char snip ?

The right thing to do is to have

SoB ...
'--- ' line
Changelog is _here_


-- 
With Best Regards,
Andy Shevchenko