Re: [PATCH v2] drm/mediatek: add AAL output size configuration

[Chun-Kuang Hu]

Hi, Jason:

jason-jh.lin <jason-jh.lin@xxxxxxxxxxxx> 於 2021年8月10日 週二 上午10:55寫道：
>
> To avoid the output width and height is incorrect,
> AAL_OUTPUT_SIZE configuration should be set.

Applied to mediatek-drm-fixes [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes

Regards,
Chun-Kuang.

>
> Fixes: 0664d1392c26 ("drm/mediatek: Add AAL engine basic function")
> Signed-off-by: jason-jh.lin <jason-jh.lin@xxxxxxxxxxxx>
> ---
> Change in v2:
> - fix to one line
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> index 75bc00e17fc4..50d20562e612 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> @@ -34,6 +34,7 @@
>
>  #define DISP_AAL_EN                            0x0000
>  #define DISP_AAL_SIZE                          0x0030
> +#define DISP_AAL_OUTPUT_SIZE                   0x04d8
>
>  #define DISP_DITHER_EN                         0x0000
>  #define DITHER_EN                              BIT(0)
> @@ -197,6 +198,7 @@ static void mtk_aal_config(struct device *dev, unsigned int w,
>         struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
>
>         mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE);
> +       mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_OUTPUT_SIZE);
>  }
>
>  static void mtk_aal_gamma_set(struct device *dev, struct drm_crtc_state *state)
> --
> 2.18.0
>