Re: [PATCH 04/12] ASoC: cs42l42: Don't reconfigure the PLL while it is running

From: Richard Fitzgerald
Date: Wed Aug 11 2021 - 06:56:56 EST


On 10/08/2021 16:49, Mark Brown wrote:
On Tue, Aug 10, 2021 at 04:37:51PM +0100, Richard Fitzgerald wrote:
cs42l42_pcm_hw_params() must only configure the PLL if this is the first
stream to become active, otherwise it will be overwriting the registers
while the PLL is running.

Shouldn't the PLL code be noticing problematic attempts to reconfigure
the PLL while it's active rather than the individual callers?


I'll push a new version with cs42l42_pll_config() doing the check.