Re: [PATCH v2] i2c: dev: zero out array used for i2c reads from userspace

[Greg Kroah-Hartman]

On Tue, Aug 10, 2021 at 10:55:11PM +0200, Wolfram Sang wrote:
> On Thu, Jul 29, 2021 at 04:35:32PM +0200, Greg Kroah-Hartman wrote:
> > If an i2c driver happens to not provide the full amount of data that a
> > user asks for, it is possible that some uninitialized data could be sent
> > to userspace.  While all in-kernel drivers look to be safe, just be sure
> > by initializing the buffer to zero before it is passed to the i2c driver
> > so that any future drivers will not have this issue.
> > 
> > Also properly copy the amount of data recvieved to the userspace buffer,
> > as pointed out by Dan Carpenter.
> > 
> > Reported-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> > Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Cc: stable <stable@xxxxxxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> Fixed checkpatch warning "WARNING: Invalid email format for stable:
> 'stable <stable@xxxxxxxxxxxxxxx>', prefer 'stable@xxxxxxxxxxxxxxx' " and
> applied to for-current, thanks!

That is a crazy warning, never even knew it was there.  But as the
stable maintainer, it does not look correct as both are just fine...

Anyway, thanks for taking the patch!

greg k-h