Re: [PATCH v14 079/138] mm/filemap: Add readahead_folio()

From: David Howells
Date: Tue Aug 10 2021 - 17:34:58 EST


Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> wrote:

> The pointers stored in the page cache are folios, by definition.
> This change comes with a behaviour change -- callers of readahead_folio()
> are no longer required to put the page reference themselves. This matches
> how readpage works, rather than matching how readpages used to work.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

For some of the things I'm looking at, this is actually inconvenient, but I
guess I can take an extra ref if I need it.

Reviewed-by: David Howells <dhowells@xxxxxxxxxx>