Re: [PATCH v3 1/2] ipack: tpci200: fix many double free issues in tpci200_pci_probe

From: Dongliang Mu
Date: Tue Aug 10 2021 - 06:06:24 EST


On Tue, Aug 10, 2021 at 5:53 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Aug 10, 2021 at 03:49:21PM +0800, Dongliang Mu wrote:
> > The function tpci200_register called by tpci200_install and
> > tpci200_unregister called by tpci200_uninstall are in pair. However,
> > tpci200_unregister has some cleanup operations not in the
> > tpci200_register. So the error handling code of tpci200_pci_probe has
> > many different double free issues.
> >
> > Fix this problem by moving those cleanup operations out of
> > tpci200_unregister, into tpci200_pci_remove and reverting
> > the previous commit 9272e5d0028d ("ipack/carriers/tpci200:
> > Fix a double free in tpci200_pci_probe").
> >
> > Reported-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
> > Fixes: 9272e5d0028d ("ipack/carriers/tpci200: Fix a double free in tpci200_pci_probe")
> > Signed-off-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
> > ---
>
> No cc: stable markings on the patches?
>

I am sorry that I usually ignore that tag. I have sent a v4 patch with
the Cc tag.

Dongliang Mu

> :(
>