Re: [PATCH v6 1/2] PM / Domains: Add support for 'required-opps' to set default perf state

[Dmitry Osipenko]

04.08.2021 13:58, Rajendra Nayak пишет:
> @@ -2637,6 +2643,8 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,
>  {
>  	struct of_phandle_args pd_args;
>  	struct generic_pm_domain *pd;
> +	struct device_node *np;
> +	int pstate;
>  	int ret;
>  
>  	ret = of_parse_phandle_with_args(dev->of_node, "power-domains",
> @@ -2675,10 +2683,26 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,
>  		genpd_unlock(pd);
>  	}
>  
> -	if (ret)
> +	if (ret) {
>  		genpd_remove_device(pd, dev);
> +		return -EPROBE_DEFER;
> +	}
> +
> +	/* Set the default performance state */
> +	np = dev->of_node;
> +	if (of_parse_phandle(np, "required-opps", index)) {
> +		pstate = of_get_required_opp_performance_state(np, index);
> +		if (pstate < 0) {
> +			ret = pstate;
> +			dev_err(dev, "failed to set required performance state for power-domain %s: %d\n",
> +				pd->name, ret);
> +		} else {
> +			dev_pm_genpd_set_performance_state(dev, pstate);
> +			dev_gpd_data(dev)->default_pstate = pstate;
> +		}
> +	}

Why performance state is set after genpd_power_on()?