Re: [PATCH] scripts/Makefile.clang: default to LLVM_IAS=1

From: Masahiro Yamada
Date: Thu Aug 05 2021 - 10:01:10 EST


On Tue, Aug 3, 2021 at 10:33 AM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> On Mon, Aug 02, 2021 at 04:43:03PM -0700, Nick Desaulniers wrote:
> > +++ b/Documentation/kbuild/llvm.rst
> > @@ -60,17 +60,14 @@ They can be enabled individually. The full list of the parameters: ::
> > OBJCOPY=llvm-objcopy OBJDUMP=llvm-objdump READELF=llvm-readelf \
> > HOSTCC=clang HOSTCXX=clang++ HOSTAR=llvm-ar HOSTLD=ld.lld
> >
> > -Currently, the integrated assembler is disabled by default. You can pass
> > -``LLVM_IAS=1`` to enable it.
> > +Currently, the integrated assembler is enabled by default. You can pass
> > +``LLVM_IAS=0`` to disable it.
>
> I'd drop the "Currently,". This is presumably going to be the default
> going forward unless there's some horrible unforeseen problem. The
> "Currently," implies that we're planning on changing it.

I agree.



--
Best Regards
Masahiro Yamada