Re: [PATCH 1/1] mfd: simple-mfd-i2c: Add support for registering devices via MFD cells

From: Lee Jones
Date: Thu Aug 05 2021 - 03:40:12 EST


On Thu, 05 Aug 2021, Michael Walle wrote:

> Hi Lee,
>
> Am 2021-08-04 16:37, schrieb Lee Jones:
> > More devices are cropping up requiring only Regmap initialisation and
> > child registration functionality. We currently only support that if
> > all required devices are represented by their own Device Tree nodes
> > complete with compatible strings.
> >
> > However, not everyone is happy with adding empty nodes that provide no
> > additional device information into the Device Tree.
> >
> > Rather than have a plethora of mostly empty, function-less drivers in
> > MFD, we'll support those simple cases in here instead via MFD cells.
> >
> > Cc: Michael Walle <michael@xxxxxxxx>
> > Cc: Mark Brown <broonie@xxxxxxxxxx>
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > ---
> >
> > Michael, could you please test this on your platform to ensure I
> > didn't break anything please?
> >
>
> I'm getting a null pointer dereference.

Perfect. Will fix.

Thanks for testing.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog