Re: [PATCH 14/38] coresight: Replace deprecated CPU-hotplug functions.

From: Mathieu Poirier
Date: Tue Aug 03 2021 - 11:52:28 EST


On Tue, Aug 03, 2021 at 04:15:57PM +0200, Sebastian Andrzej Siewior wrote:
> The functions get_online_cpus() and put_online_cpus() have been
> deprecated during the CPU hotplug rework. They map directly to
> cpus_read_lock() and cpus_read_unlock().
>
> Replace deprecated CPU-hotplug functions with the official version.
> The behavior remains unchanged.
>
> Cc: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> Cc: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
> Cc: Mike Leach <mike.leach@xxxxxxxxxx>
> Cc: Leo Yan <leo.yan@xxxxxxxxxx>
> Cc: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
> Cc: coresight@xxxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
> drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> index 9731d3a960735..00de46565bc40 100644
> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> @@ -588,11 +588,11 @@ static int debug_probe(struct amba_device *adev, const struct amba_id *id)
>
> drvdata->base = base;
>
> - get_online_cpus();
> + cpus_read_lock();
> per_cpu(debug_drvdata, drvdata->cpu) = drvdata;
> ret = smp_call_function_single(drvdata->cpu, debug_init_arch_data,
> drvdata, 1);
> - put_online_cpus();
> + cpus_read_unlock();
>

Applied - thanks,
Mathieu

> if (ret) {
> dev_err(dev, "CPU%d debug arch init failed\n", drvdata->cpu);
> --
> 2.32.0
>