Re: [PATCH v2] pktgen: Fix invalid clone_skb override

From: Jakub Kicinski
Date: Mon Aug 02 2021 - 13:21:04 EST


On Mon, 2 Aug 2021 17:12:07 +0000 Nicholas Richardson wrote:
> From: Nick Richardson <richardsonnick@xxxxxxxxxx>
>
> When the netif_receive xmit_mode is set, a line is supposed to set
> clone_skb to a default 0 value. This line is not reached due to a line
> that checks if clone_skb is more than zero and returns -ENOTSUPP.
>
> Removes line that defaults clone_skb to zero.

s/Removes/Remove/
s/defaults/sets/

> -ENOTSUPP is returned
> if clone_skb is more than zero.

That's already mentioned in the previous paragraph.

> If clone_skb is equal to zero then the
> xmit_mode is set to netif_receive as usual and no error is returned.

Please add the explanation why clone_skb can't be negative to the
commit message.