Re: [PATCH] dyndbg: add special aux_print framework

From: kernel test robot
Date: Sun Aug 01 2021 - 01:52:34 EST


Hi Jim,

I love your patch! Yet something to improve:

[auto build test ERROR on tegra-drm/drm/tegra/for-next]
[also build test ERROR on linux/master linus/master v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Jim-Cromie/dyndbg-add-special-aux_print-framework/20210801-113749
base: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next
config: i386-randconfig-r024-20210801 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/1bf22862d95adc83487ade34fe1c42707f94ac4d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jim-Cromie/dyndbg-add-special-aux_print-framework/20210801-113749
git checkout 1bf22862d95adc83487ade34fe1c42707f94ac4d
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

lib/dynamic_debug.c: In function '__dynamic_pr_debug':
>> lib/dynamic_debug.c:651:17: error: 'struct _ddebug' has no member named 'aux_channel'
651 | if (descriptor->aux_channel) {
| ^~
lib/dynamic_debug.c:653:16: error: 'struct _ddebug' has no member named 'aux_channel'
653 | (*descriptor->aux_channel)
| ^~


vim +651 lib/dynamic_debug.c

626
627 void __dynamic_pr_debug(struct _ddebug *descriptor, const char *fmt, ...)
628 {
629 va_list args;
630 struct va_format vaf;
631 char buf[PREFIX_SIZE] = "";
632
633 BUG_ON(!descriptor);
634 BUG_ON(!fmt);
635
636 va_start(args, fmt);
637
638 vaf.fmt = fmt;
639 vaf.va = &args;
640
641 printk(KERN_DEBUG "%s%pV", dynamic_emit_prefix(descriptor, buf), &vaf);
642
643 if (descriptor->flags & _DPRINTK_FLAGS_PRINT_AUX) {
644 /* our model:
645 drm_trace_printf("%s%s[" DRM_NAME ":%ps] %pV",
646 dev ? dev_name(dev) : "", dev ? " " : "",
647 __builtin_return_address(0), &vaf);
648 */
649 pr_info("reached check aux\n");
650
> 651 if (descriptor->aux_channel) {
652 pr_info("calling aux\n");
653 (*descriptor->aux_channel)
654 ("%s[DRM_mumble :%ps] %pV", buf,
655 __builtin_return_address(0), &vaf);
656 }
657 }
658 va_end(args);
659 }
660 EXPORT_SYMBOL(__dynamic_pr_debug);
661

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip