Re: [PATCH 8/9] phy: phy-mtk-mipi-dsi: remove dummy assignment of error number

From: Chun-Kuang Hu
Date: Fri Jul 30 2021 - 12:24:46 EST


Hi, Chunfeng:

Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx> 於 2021年7月28日 週三 下午3:59寫道:
>
> Return the error number directly without assignment

Acked-by: Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx>

>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
> ---
> drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> index 01cf31633019..61c942fbf4a1 100644
> --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> @@ -203,10 +203,8 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev)
> phy_set_drvdata(phy, mipi_tx);
>
> phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> - if (IS_ERR(phy_provider)) {
> - ret = PTR_ERR(phy_provider);
> - return ret;
> - }
> + if (IS_ERR(phy_provider))
> + return PTR_ERR(phy_provider);
>
> mipi_tx->dev = dev;
>
> --
> 2.18.0
>