Re: [PATCH] fs: make d_path-like functions all have unsigned size

From: Al Viro
Date: Tue Jul 27 2021 - 11:17:39 EST


On Tue, Jul 27, 2021 at 04:07:47PM +0100, Matthew Wilcox wrote:

> umm ... what if someone passes in -ENOMEM as buflen? Not saying we
> have such a path right now, but I could imagine it happening.
>
> if (unlikely(buflen < 0))
> return ERR_PTR(buflen);
> if (unlikely(buflen > 0x8000)) {
> buf += buflen - 0x8000;
> buflen = 0x8000;
> }

Not really. You don't want ERR_PTR() of random negative numbers to start
flying around...