Re: [PATCH v3 1/2] mm: introduce process_mrelease system call

From: Shakeel Butt
Date: Fri Jul 23 2021 - 09:41:10 EST


On Thu, Jul 22, 2021 at 11:20 PM Michal Hocko <mhocko@xxxxxxxx> wrote:
>
> On Thu 22-07-21 21:47:56, Suren Baghdasaryan wrote:
> > On Thu, Jul 22, 2021, 7:04 PM Shakeel Butt <shakeelb@xxxxxxxxxx> wrote:
> >
> > > On Thu, Jul 22, 2021 at 6:14 PM Suren Baghdasaryan <surenb@xxxxxxxxxx>
> > > wrote:
> > > >
> > > [...]
> > > > +
> > > > + mmap_read_lock(mm);
> > >
> > > How about mmap_read_trylock(mm) and return -EAGAIN on failure?
> > >
> >
> > That sounds like a good idea. Thanks! I'll add that in the next respin.
>
> Why is that a good idea? Can you do anything meaningful about the
> failure other than immediately retry the syscall and hope for the best?
>

Yes we can. Based on the situation/impact we can select more victims.