Re: [RFC] dsa: register every port with of_platform

From: Ansuel Smith
Date: Fri Jul 23 2021 - 07:30:24 EST


On Fri, Jul 23, 2021 at 01:25:02PM +0200, Michael Walle wrote:
> Am 2021-07-23 13:18, schrieb Ansuel Smith:
> > On Fri, Jul 23, 2021 at 01:13:28PM +0200, Michael Walle wrote:
> > > > The declaration of a different mac-addr using the nvmem framework is
> > > > currently broken. The dsa code uses the generic of_get_mac_address where
> > > > the nvmem function requires the device node to be registered in the
> > > > of_platform to be found by of_find_device_by_node. Register every port
> > >
> > > Which tree are you on? This should be fixed with
> > >
> > > f10843e04a07 of: net: fix of_get_mac_addr_nvmem() for non-platform
> > > devices
> > >
> > > -michael
> >
> > Thx a lot for the hint. So yes I missed that the problem was already
> > fixed. Sorry for the mess. Any idea if that will be backported?
>
> I didn't include a Fixes tag, so it won't be automatically
> backported. Also I'm not sure if it qualifies for the stable trees
> because no in-tree users seem to be affected, no?
>
> -michael

Also the patch seems very large. Anyway again thx a lot for the work and
the quick hint. Time to backport to 5.10 and 5.4 for openwrt.