Re: [PATCH] gpu: host1x: select CONFIG_SYNC_FILE

[Mikko Perttunen]

On 7/23/21 12:17 PM, Mikko Perttunen wrote:
> Hi Arnd,
>
> I think the best fix for this is to just remove that function -- it is 
> currently not used anywhere. I posted a patch to do that, but Thierry is 
> currently on vacation so it hasn't been picked up yet.

.. and sorry for the top post ..

Mikko

> thanks,
> Mikko
>
> On 7/23/21 12:14 PM, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > With the addition of the DMA fence, the host1x driver now fails to
> > build without the sync_file helper:
> >
> > arm-linux-gnueabi-ld: drivers/gpu/host1x/fence.o: in function 
> > `host1x_fence_create_fd':
> > fence.c:(.text+0x624): undefined reference to `sync_file_create'
> >
> > Fixes: ad0529424def ("gpu: host1x: Add DMA fence implementation")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > ---
> >   drivers/gpu/host1x/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> > index 6dab94adf25e..6f7ea1720a39 100644
> > --- a/drivers/gpu/host1x/Kconfig
> > +++ b/drivers/gpu/host1x/Kconfig
> > @@ -3,6 +3,7 @@ config TEGRA_HOST1X
> >       tristate "NVIDIA Tegra host1x driver"
> >       depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> >       select IOMMU_IOVA
> > +    select SYNC_FILE
> >       help
> >         Driver for the NVIDIA Tegra host1x hardware.