Re: [PATCH] extcon: usb-gpio: Use the right includes

From: Chanwoo Choi
Date: Fri Jul 23 2021 - 01:28:22 EST


On 7/16/21 4:06 AM, Linus Walleij wrote:
> The USB GPIO extcon driver does not use any of the legacy
> includes <linux/gpio.h> or <linux/of_gpio.h> but
> exploits the fact that this brings in <linux/mod_device_table.h>.
> Fix this up by using the right includes.
>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> drivers/extcon/extcon-usb-gpio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index f06be6d4e2a9..0cb440bdd5cb 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -7,18 +7,17 @@
> */
>
> #include <linux/extcon-provider.h>
> -#include <linux/gpio.h>
> #include <linux/gpio/consumer.h>
> #include <linux/init.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/workqueue.h>
> #include <linux/pinctrl/consumer.h>
> +#include <linux/mod_devicetable.h>
>
> #define USB_GPIO_DEBOUNCE_MS 20 /* ms */
>
>

Applied it. Thanks.

--
Best Regards,
Chanwoo Choi
Samsung Electronics