RE: [PATCH v5 06/14] RDMA/irdma: Use irq_update_affinity_hint

[Nikolova, Tatyana E]

> -----Original Message-----
> From: Nitesh Narayan Lal <nitesh@xxxxxxxxxx>
> Sent: Tuesday, July 20, 2021 6:26 PM
> To: linux-kernel@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; intel-wired-
> lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-api@xxxxxxxxxxxxxxx;
> linux-pci@xxxxxxxxxxxxxxx; tglx@xxxxxxxxxxxxx; Brandeburg, Jesse
> <jesse.brandeburg@xxxxxxxxx>; robin.murphy@xxxxxxx;
> mtosatti@xxxxxxxxxx; mingo@xxxxxxxxxx; jbrandeb@xxxxxxxxxx;
> frederic@xxxxxxxxxx; juri.lelli@xxxxxxxxxx; abelits@xxxxxxxxxxx;
> bhelgaas@xxxxxxxxxx; rostedt@xxxxxxxxxxx; peterz@xxxxxxxxxxxxx;
> davem@xxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; sfr@xxxxxxxxxxxxxxxx;
> stephen@xxxxxxxxxxxxxxxxxx; rppt@xxxxxxxxxxxxxxxxxx;
> chris.friesen@xxxxxxxxxxxxx; maz@xxxxxxxxxx; nhorman@xxxxxxxxxxxxx;
> pjwaskiewicz@xxxxxxxxx; sassmann@xxxxxxxxxx; thenzl@xxxxxxxxxx;
> kashyap.desai@xxxxxxxxxxxx; sumit.saxena@xxxxxxxxxxxx;
> shivasharan.srikanteshwara@xxxxxxxxxxxx;
> sathya.prakash@xxxxxxxxxxxx; sreekanth.reddy@xxxxxxxxxxxx;
> suganath-prabu.subramani@xxxxxxxxxxxx; james.smart@xxxxxxxxxxxx;
> dick.kennedy@xxxxxxxxxxxx; jkc@xxxxxxxxxx; Latif, Faisal
> <faisal.latif@xxxxxxxxx>; Saleem, Shiraz <shiraz.saleem@xxxxxxxxx>;
> tariqt@xxxxxxxxxx; ahleihel@xxxxxxxxxx; kheib@xxxxxxxxxx;
> borisp@xxxxxxxxxx; saeedm@xxxxxxxxxx; benve@xxxxxxxxx;
> govind@xxxxxxx; jassisinghbrar@xxxxxxxxx;
> ajit.khaparde@xxxxxxxxxxxx; sriharsha.basavapatna@xxxxxxxxxxxx;
> somnath.kotur@xxxxxxxxxxxx; nilal@xxxxxxxxxx; Nikolova, Tatyana E
> <tatyana.e.nikolova@xxxxxxxxx>; Ismail, Mustafa
> <mustafa.ismail@xxxxxxxxx>; ahs3@xxxxxxxxxx; leonro@xxxxxxxxxx;
> chandrakanth.patil@xxxxxxxxxxxx; bjorn.andersson@xxxxxxxxxx;
> chunkuang.hu@xxxxxxxxxx; yongqiang.niu@xxxxxxxxxxxx;
> baolin.wang7@xxxxxxxxx; poros@xxxxxxxxxx; minlei@xxxxxxxxxx;
> emilne@xxxxxxxxxx; jejb@xxxxxxxxxxxxx; martin.petersen@xxxxxxxxxx;
> _govind@xxxxxxx; kabel@xxxxxxxxxx; viresh.kumar@xxxxxxxxxx;
> Tushar.Khandelwal@xxxxxxx; kuba@xxxxxxxxxx
> Subject: [PATCH v5 06/14] RDMA/irdma: Use irq_update_affinity_hint
> 
> The driver uses irq_set_affinity_hint() to update the affinity_hint mask that
> is consumed by the userspace to distribute the interrupts. However, under
> the hood irq_set_affinity_hint() also applies the provided cpumask (if not
> NULL) as the affinity for the given interrupt which is an undocumented side
> effect.
> 
> To remove this side effect irq_set_affinity_hint() has been marked as
> deprecated and new interfaces have been introduced. Hence, replace the
> irq_set_affinity_hint() with the new interface irq_update_affinity_hint() that
> only updates the affinity_hint pointer.
> 
> Signed-off-by: Nitesh Narayan Lal <nitesh@xxxxxxxxxx>
> ---
>  drivers/infiniband/hw/irdma/hw.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/hw.c
> b/drivers/infiniband/hw/irdma/hw.c
> index 7afb8a6a0526..ec8de708a4df 100644
> --- a/drivers/infiniband/hw/irdma/hw.c
> +++ b/drivers/infiniband/hw/irdma/hw.c
> @@ -537,7 +537,7 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf,
>  	struct irdma_sc_dev *dev = &rf->sc_dev;
> 
>  	dev->irq_ops->irdma_dis_irq(dev, msix_vec->idx);
> -	irq_set_affinity_hint(msix_vec->irq, NULL);
> +	irq_update_affinity_hint(msix_vec->irq, NULL);
>  	free_irq(msix_vec->irq, dev_id);
>  }
> 
> @@ -1087,7 +1087,7 @@ irdma_cfg_ceq_vector(struct irdma_pci_f *rf,
> struct irdma_ceq *iwceq,
>  	}
>  	cpumask_clear(&msix_vec->mask);
>  	cpumask_set_cpu(msix_vec->cpu_affinity, &msix_vec->mask);
> -	irq_set_affinity_hint(msix_vec->irq, &msix_vec->mask);
> +	irq_update_affinity_hint(msix_vec->irq, &msix_vec->mask);
>  	if (status) {
>  		ibdev_dbg(&rf->iwdev->ibdev, "ERR: ceq irq config fail\n");
>  		return IRDMA_ERR_CFG;
> --
> 2.27.0

Acked-by: Tatyana Nikolova <tatyana.e.nikolova@xxxxxxxxx>