Re: [PATCH] checkpatch: add grammatical judgement for total output

From: Joe Perches
Date: Thu Jul 22 2021 - 13:01:30 EST


On Thu, 2021-07-22 at 18:04 +0800, Hu Haowen wrote:
> On 2021/7/22 上午12:03, Joe Perches wrote:
> > On Wed, 2021-07-21 at 23:14 +0800, Hu Haowen wrote:
> > > There lacked a English grammatical identification within the final
> > > output of checkpatch.pl such as the following:
> > >
> > >     total: 1 errors, 11 warnings, 4094 lines checked
> > >                   ^
> > >
> > > Which violated the rule about the usage of the singular form and the
> > > plural form. Hence fix the issue up and make it output the proper
> > > sentence.
> > NAK
> >
> > I appreciate the desire for precision but I don't want to require
> > any automated downstream user of checkpatch to be changed.
> >
> > I think users understand the output even though it may not be
> > grammatically correct in some cases.
>
>
> How about another modification, which turns "errors" into "error(s)"?
> In this case not only did the meaning convey but automated users won't
> be confused toward their automatic programs.

I still think this doesn't need to be changed.