Re: [PATCH V8 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks

From: Zhu, Lingshan
Date: Thu Jul 22 2021 - 00:02:27 EST




On 7/21/2021 7:57 PM, Like Xu wrote:
On 16/7/2021 4:53 pm, Zhu Lingshan wrote:
+    } else if (xenpmu_data->pmu.r.regs.cpl & 3)

Lingshan, serious for this version ?

arch/x86/xen/pmu.c:438:9: error: expected identifier or ‘(’ before ‘return’
  438 |         return state;
      |         ^~~~~~
arch/x86/xen/pmu.c:439:1: error: expected identifier or ‘(’ before ‘}’ token
  439 | }
      | ^
arch/x86/xen/pmu.c: In function ‘xen_guest_state’:
arch/x86/xen/pmu.c:436:9: error: control reaches end of non-void function [-Werror=return-type]
  436 |         }
      |         ^
cc1: some warnings being treated as errors

+            state |= PERF_GUEST_USER;
      }
forgot to enable XEN build in .config, V9 fixes this will come soon