Re: [PATCH v2 08/10] arm64: dts: qcom: sc7280: Add nodes to boot modem

[Sibi Sankar]

On 2021-07-21 11:14, Stephen Boyd wrote:
> Quoting Sibi Sankar (2021-07-20 03:12:58)
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi 
> > b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index 5ed7a511bfc9..3fb6a6ef39f8 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -1219,6 +1224,21 @@
> >                         };
> >                 };
> >
> > +               imem@146aa000 {
>
> is sram a more appropriate node name here? Is imem a generic node name
> in DT spec?

binding check for qcom,pil-info.yaml
didn't complain so I just followed
it. AFAICS, sram isn't mentioned in
generic node names either.

> > +                       compatible = "syscon", "simple-mfd";
> > +                       reg = <0 0x146aa000 0 0x2000>;
> > +
> > +                       #address-cells = <2>;
> > +                       #size-cells = <2>;
> > +
> > +                       ranges = <0 0x0 0 0x146aa000 0 0x2000>;
> > +
> > +                       pil-reloc@94c {
> > +                               compatible = "qcom,pil-reloc-info";
> > +                               reg = <0 0x94c 0 0xc8>;
> > +                       };
> > +               };
> > +

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.