Re: [PATCH AUTOSEL 4.9 17/18] scsi: be2iscsi: Fix some missing space in some messages

From: Sasha Levin
Date: Wed Jul 21 2021 - 06:49:21 EST


On Fri, Jul 16, 2021 at 09:22:43PM +0200, Marion & Christophe JAILLET wrote:

Le 14/07/2021 à 21:48, Sasha Levin a écrit :
From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

[ Upstream commit c7fa2c855e892721bafafdf6393342c000e0ef77 ]

Fix a few style issues reported by checkpatch.pl:

- Avoid duplicated word in comment.

- Add missing space in messages.

- Unneeded continuation line character.

- Unneeded extra spaces.

- Unneeded log message after memory allocation failure.

Link: https://lore.kernel.org/r/8cb62f0eb96ec7ce7a73fe97cb4490dd5121ecff.1623482155.git.christophe.jaillet@xxxxxxxxxx
Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

Hi,

I always appreciate to have some patches backported, but in this particular case, I wonder what is the rational to backport up to 4.9 some checkpatch warning about log message?

Keeping code aligned to ease other future backport?

I thought that the rule for backport was that it needed to fix a real issue (and sometimes a real 'potential' issue)

I think that I brought it in as a dependency for something else, but I
don't see what it was. I'll drop it then, thanks!

--
Thanks,
Sasha