Re: [PATCH v5 1/3] dt-bindings: pwm: Add Xilinx AXI Timer

[Sean Anderson]

On 7/20/21 9:11 AM, Rob Herring wrote:
> On Mon, 19 Jul 2021 18:13:20 -0400, Sean Anderson wrote:
> > This adds a binding for the Xilinx LogiCORE IP AXI Timer. This device is a
> > "soft" block, so it has some parameters which would not be configurable in
> > most hardware. This binding is usually automatically generated by Xilinx's
> > tools, so the names and values of some properties should be kept as they
> > are, if possible. In addition, this binding is already in the kernel at
> > arch/microblaze/boot/dts/system.dts, and in user software such as QEMU.
> >
> > The existing driver uses the clock-frequency property, or alternatively the
> > /cpus/timebase-frequency property as its frequency input. Because these
> > properties are deprecated, they have not been included with this schema.
> > All new bindings should use the clocks/clock-names properties to specify
> > the parent clock.
> >
> > Because we need to init timer devices so early in boot, we determine if we
> > should use the PWM driver or the clocksource/clockevent driver by the
> > presence/absence, respectively, of #pwm-cells. Because both counters are
> > used by the PWM, there is no need for a separate property specifying which
> > counters are to be used for the PWM.
> >
> > Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx>
> > ---
> >
> > Changes in v5:
> > - Update commit message to reflect revisions
> > - Fix indentation lint
> > - Add example for timer binding
> > - Remove xlnx,axi-timer-2.0 compatible string
> > - Move schema into the timer directory
> >
> > Changes in v4:
> > - Remove references to generate polarity so this can get merged
> > - Predicate PWM driver on the presence of #pwm-cells
> > - Make some properties optional for clocksource drivers
> >
> > Changes in v3:
> > - Mark all boolean-as-int properties as deprecated
> > - Add xlnx,pwm and xlnx,gen?-active-low properties.
> > - Make newer replacement properties mutually-exclusive with what they
> >   replace
> > - Add an example with non-deprecated properties only.
> >
> > Changes in v2:
> > - Use 32-bit addresses for example binding
> >
> >  .../bindings/timer/xlnx,xps-timer.yaml        | 91 +++++++++++++++++++
> >  1 file changed, 91 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/timer/xlnx,xps-timer.yaml
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> ./Documentation/devicetree/bindings/timer/xlnx,xps-timer.yaml: $id: relative path/filename doesn't match actual path or filename
> 	expected: http://devicetree.org/schemas/timer/xlnx,xps-timer.yaml#
> \ndoc reference errors (make refcheckdocs):

Ah, looks like I neglected to re-run tests after moving this file. Will fix in v6.

--Sean

> See https://patchwork.ozlabs.org/patch/1507329
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.