Re: [PATCH v2 4/4] x86/tdx: Add tdg_debug_enabled() interface

From: Dave Hansen
Date: Tue Jul 20 2021 - 12:38:49 EST


On 7/19/21 9:33 PM, Kuppuswamy Sathyanarayanan wrote:
> Add a new interface to detect the TDX debug mode. This will be used by
> follow-on patches. Examples of its usage are, when adding command line
> debug options to disable TDX features like driver or port filter,
> tdg_debug_enabled() is used to make sure it is used only in debug
> mode.

This patch must be dropped from this series. There is no user for this
code. Please introduce these in the series where they are used.

We don't know whether this is a good implementation or not without
seeing the users. For instance, should this be an X86_FEATURE?