Re: [PATCH 5.4] net: moxa: Use devm_platform_get_and_ioremap_resource()

From: Greg KH
Date: Mon Jul 19 2021 - 08:40:15 EST


On Fri, Jul 16, 2021 at 05:32:45PM +0800, Yang Yingliang wrote:
> [ Upstream commit 35cba15a504bf4f585bb9d78f47b22b28a1a06b2 ]
>
> Use devm_platform_get_and_ioremap_resource() to simplify
> code and avoid a null-ptr-deref by checking 'res' in it.
>
> [yyl: since devm_platform_get_and_ioremap_resource() is introduced
> in linux-5.7, so just check the return value after calling
> platform_get_resource()]
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/moxa/moxart_ether.c | 4 ++++
> 1 file changed, 4 insertions(+)

Now queued up, thanks.

greg k-h