Re: [PATCH] staging/ks7010: Remove all strcpy() uses in favor of strscpy()

From: Dan Carpenter
Date: Mon Jul 19 2021 - 01:27:12 EST


On Sat, Jul 17, 2021 at 05:37:59PM +0200, Len Baker wrote:
> @@ -1808,7 +1808,7 @@ static int ks_wlan_get_firmware_version(struct net_device *dev,
> {
> struct ks_wlan_private *priv = netdev_priv(dev);
>
> - strcpy(extra, priv->firmware_version);
> + strscpy(extra, priv->firmware_version, sizeof(extra));

Extra is a pointer and not an array so this doesn't work.

regards,
dan carpenter