Re: [PATCH v4 08/12] power: supply: smb347-charger: Remove caching of charger state

From: Dmitry Osipenko
Date: Sat Jul 17 2021 - 13:29:39 EST


17.07.2021 19:20, Sebastian Reichel пишет:
> Hi,
>
> On Sat, Jul 17, 2021 at 03:11:08PM +0300, Dmitry Osipenko wrote:
>> Regmap already provides us with the caching, so remove caching of charger
>> state to make code cleaner.
>
> cache_type is not initialized in smb347's regmap config and thus
> set to 0 = REGCACHE_NONE:
>
> static const struct regmap_config smb347_regmap = {
> .reg_bits = 8,
> .val_bits = 8,
> .max_register = SMB347_MAX_REGISTER,
> .volatile_reg = smb347_volatile_reg,
> .readable_reg = smb347_readable_reg,
> };

Good catch, thank you. I'll add patch to enable caching.