Re: [PATCH v3] audit: fix memory leak in nf_tables_commit

From: Pablo Neira Ayuso
Date: Fri Jul 16 2021 - 20:22:53 EST


On Wed, Jul 14, 2021 at 11:27:03AM +0800, Dongliang Mu wrote:
> In nf_tables_commit, if nf_tables_commit_audit_alloc fails, it does not
> free the adp variable.
>
> Fix this by adding nf_tables_commit_audit_free which frees
> the linked list with the head node adl.
>
> backtrace:
> kmalloc include/linux/slab.h:591 [inline]
> kzalloc include/linux/slab.h:721 [inline]
> nf_tables_commit_audit_alloc net/netfilter/nf_tables_api.c:8439 [inline]
> nf_tables_commit+0x16e/0x1760 net/netfilter/nf_tables_api.c:8508
> nfnetlink_rcv_batch+0x512/0xa80 net/netfilter/nfnetlink.c:562
> nfnetlink_rcv_skb_batch net/netfilter/nfnetlink.c:634 [inline]
> nfnetlink_rcv+0x1fa/0x220 net/netfilter/nfnetlink.c:652
> netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline]
> netlink_unicast+0x2c7/0x3e0 net/netlink/af_netlink.c:1340
> netlink_sendmsg+0x36b/0x6b0 net/netlink/af_netlink.c:1929
> sock_sendmsg_nosec net/socket.c:702 [inline]
> sock_sendmsg+0x56/0x80 net/socket.c:722

Applied, thanks.