RE: [PATCH RFC 07/13] iomap: simplify iomap_swapfile_fail() with '%pD' specifier

[Justin He]

Hi Christoph

> -----Original Message-----
> From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Sent: Friday, July 16, 2021 2:11 PM
> To: Justin He <Justin.He@xxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Linus Torvalds <torvalds@linux-
> foundation.org>; Christoph Hellwig <hch@xxxxxxxxxxxxx>; nd <nd@xxxxxxx>;
> Darrick J. Wong <djwong@xxxxxxxxxx>; linux-xfs@xxxxxxxxxxxxxxx; linux-
> fsdevel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH RFC 07/13] iomap: simplify iomap_swapfile_fail() with
> '%pD' specifier
> 
> On Thu, Jul 15, 2021 at 11:15:27AM +0800, Jia He wrote:
> > After the behavior of '%pD' is change to print the full path of file,
> > iomap_swapfile_fail() can be simplified.
> >
> > Given the space with proper length would be allocated in vprintk_store(),
> > the kmalloc() is not required any more.
> >
> > Besides, the previous number postfix of '%pD' in format string is
> > pointless.
> 
> This also touched iomap_dio_actor, but the commit og only mentions
> iomap_swapfile_fail.
Okay, I will refine the msg in next version.
Thanks


--
Cheers,
Justin (Jia He)