RE: [PATCH] qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()

[Justin He]

> -----Original Message-----
> From: patchwork-bot+netdevbpf@xxxxxxxxxx <patchwork-
> bot+netdevbpf@xxxxxxxxxx>
> Sent: Friday, July 16, 2021 3:50 AM
> To: Justin He <Justin.He@xxxxxxx>
> Cc: aelior@xxxxxxxxxxx; GR-everest-linux-l2@xxxxxxxxxxx;
> davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; nd <nd@xxxxxxx>
> Subject: Re: [PATCH] qed: fix possible unpaired spin_{un}lock_bh in
> _qed_mcp_cmd_and_union()
> 
> Hello:
> 
> This patch was applied to netdev/net.git (refs/heads/master):
> 
> On Thu, 15 Jul 2021 16:08:21 +0800 you wrote:
> > Liajian reported a bug_on hit on a ThunderX2 arm64 server with FastLinQ
> > QL41000 ethernet controller:
> >  BUG: scheduling while atomic: kworker/0:4/531/0x00000200
> >   [qed_probe:488()]hw prepare failed
> >   kernel BUG at mm/vmalloc.c:2355!
> >   Internal error: Oops - BUG: 0 [#1] SMP
> >   CPU: 0 PID: 531 Comm: kworker/0:4 Tainted: G W 5.4.0-77-generic #86-
> Ubuntu
> >   pstate: 00400009 (nzcv daif +PAN -UAO)
> >  Call trace:
> >   vunmap+0x4c/0x50
> >   iounmap+0x48/0x58
> >   qed_free_pci+0x60/0x80 [qed]
> >   qed_probe+0x35c/0x688 [qed]
> >   __qede_probe+0x88/0x5c8 [qede]
> >   qede_probe+0x60/0xe0 [qede]
> >   local_pci_probe+0x48/0xa0
> >   work_for_cpu_fn+0x24/0x38
> >   process_one_work+0x1d0/0x468
> >   worker_thread+0x238/0x4e0
> >   kthread+0xf0/0x118
> >   ret_from_fork+0x10/0x18
> >
> > [...]
> 
> Here is the summary with links:
>   - qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()
>     https://git.kernel.org/netdev/net/c/6206b7981a36
> 
> You are awesome, thank you!

Thanks.
If possible, please also Cc: stable@xxxxxxxxxx because the bug seemed to
be there for a long time.


--
Cheers,
Justin (Jia He)